Contents

# encoding: utf-8

module Rubocop
  module Cop
    module Lint
      # This cop checks for literals used as the conditions or as
      # operands in and/or expressions serving as the conditions of
      # if/while/until.
      #
      # @example
      #
      #   if 20
      #     do_something
      #   end
      #
      #   if some_var && true
      #     do_something
      #   end
      #
      class LiteralInCondition < Cop
        MSG = 'Literal %s appeared in a condition.'

        LITERALS = [:str, :dstr, :int, :float, :array,
                    :hash, :regexp, :nil, :true, :false]

        def on_if(node)
          check_for_literal(node)

          super
        end

        def on_while(node)
          check_for_literal(node)

          super
        end

        def on_while_post(node)
          check_for_literal(node)

          super
        end

        def on_until(node)
          check_for_literal(node)

          super
        end

        def on_until_post(node)
          check_for_literal(node)

          super
        end

        private

        def check_for_literal(node)
          cond, = *node

          # if the code node is literal we obviously have a problem
          if LITERALS.include?(cond.type)
            add_offence(:warning, cond.loc.expression,
                        format(MSG, cond.loc.expression.source))
          elsif [:and, :or].include?(cond.type)
            # alternatively we have to consider a logical node with a
            # literal argument
            *operands = *cond
            operands.each do |op|
              if LITERALS.include?(op.type)
                add_offence(:warning, op.loc.expression,
                            format(MSG, op.loc.expression.source))

              end
            end
          end
        end
      end
    end
  end
end

Version data entries

1 entries across 1 versions & 1 rubygems

Version	Path
sabat-rubocop-0.9.0	lib/rubocop/cop/lint/literal_in_condition.rb