Sha256: 42d95a71bc65ac47cb4ef597e19dee6cff08d97eb091f92d1bfc77fda218efc1
Contents?: true
Size: 1.71 KB
Versions: 182
Compression:
Stored size: 1.71 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# Sort globbed results by default in Ruby 3.0.
# This cop checks for redundant `sort` method to `Dir.glob` and `Dir[]`.
#
# @safety
# This cop is unsafe, in case of having a file and a directory with
# identical names, since directory will be loaded before the file, which
# will break `exe/files.rb` that rely on `exe.rb` file.
#
# @example
#
# # bad
# Dir.glob('./lib/**/*.rb').sort.each do |file|
# end
#
# Dir['./lib/**/*.rb'].sort.each do |file|
# end
#
# # good
# Dir.glob('./lib/**/*.rb').each do |file|
# end
#
# Dir['./lib/**/*.rb'].each do |file|
# end
#
class RedundantDirGlobSort < Base
extend AutoCorrector
extend TargetRubyVersion
minimum_target_ruby_version 3.0
MSG = 'Remove redundant `sort`.'
RESTRICT_ON_SEND = %i[sort].freeze
GLOB_METHODS = %i[glob []].freeze
def on_send(node)
return unless (receiver = node.receiver)
return unless receiver.receiver&.const_type? && receiver.receiver.short_name == :Dir
return unless GLOB_METHODS.include?(receiver.method_name)
return if multiple_argument?(receiver)
selector = node.loc.selector
add_offense(selector) do |corrector|
corrector.remove(selector)
corrector.remove(node.loc.dot)
end
end
private
def multiple_argument?(glob_method)
glob_method.arguments.count >= 2 || glob_method.first_argument&.splat_type?
end
end
end
end
end
Version data entries
182 entries across 181 versions & 19 rubygems