Contents

# frozen_string_literal: true

require 'rubocop'

module RuboCop
  module Cop
    module Standard
      class RailsControllerRenderShorthand < Cop
        MSG = 'Prefer `render` template shorthand'

        def_node_matcher :render_with_options?, <<-PATTERN
          (send nil? :render (hash $...))
        PATTERN

        def_node_matcher :action_key?, <<-PATTERN
          (pair (sym {:action :template}) $({str sym} _))
        PATTERN

        def_node_matcher :str, <<-PATTERN
          ({str sym} $_)
        PATTERN

        def investigate(*)
          @autocorrect = {}
        end

        def autocorrect(node)
          @autocorrect[node]
        end

        def on_send(node)
          if option_pairs = render_with_options?(node)
            option_pairs.each do |pair|
              next unless value_node = action_key?(pair)

              comma = option_pairs.length > 1 ? ', ' : ''
              corrected_source = node.source
                                     .sub(/#{pair.source}(,\s*)?/, '')
                                     .sub('render ', "render \"#{str(value_node)}\"#{comma}")

              @autocorrect[node] = lambda do |corrector|
                corrector.replace(node.source_range, corrected_source)
              end
              add_offense(node, location: :expression, message: "Use `#{corrected_source}` instead")
            end
          end
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rubocop-standard-2.1.1	lib/rubocop/cop/standard/rails_controller_render_shorthand.rb
rubocop-standard-2.1.0	lib/rubocop/cop/standard/rails_controller_render_shorthand.rb
rubocop-standard-2.0.1	lib/rubocop/cop/standard/rails_controller_render_shorthand.rb
rubocop-standard-2.0	lib/rubocop/cop/standard/rails_controller_render_shorthand.rb