Sha256: 40e4c89adfc8aea01884890c4f61cad994cd62f26c829f831341843b3a5556d7

Contents?: true

Size: 1.04 KB

Versions: 10

Compression:

Stored size: 1.04 KB

Contents

# encoding: utf-8
require 'rails_best_practices/reviews/review'

module RailsBestPractices
  module Reviews
    # Review a partail view file to make sure there is no instance variable.
    #
    # See the best practice details here http://rails-bestpractices.com/posts/27-replace-instance-variable-with-local-variable.
    #
    # Implementation:
    #
    # Review process:
    #   check all instance variable in partial view files,
    #   if exist, then they should be replaced with local variable
    class ReplaceInstanceVariableWithLocalVariableReview < Review
      interesting_nodes :var_ref
      interesting_files PARTIAL_VIEW_FILES

      def url
        "http://rails-bestpractices.com/posts/27-replace-instance-variable-with-local-variable"
      end

      # check ivar node in partial view file,
      # it is an instance variable, and should be replaced with local variable.
      def start_var_ref(node)
        if node.to_s.start_with?('@')
          add_error "replace instance variable with local variable"
        end
      end
    end
  end
end

Version data entries

10 entries across 10 versions & 1 rubygems

Version Path
rails_best_practices-1.8.0 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.7.2 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.7.1 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.7.0 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.6.0 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.5.3 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.5.2 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.5.1 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.5.0 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
rails_best_practices-1.4.0 lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb