Sha256: 3a63b6421c38bf7f236fc476848743e10af4e9e945f56575ca1f8960c0576386

Contents?: true

Size: 1.64 KB

Versions: 36

Compression:

Stored size: 1.64 KB

Contents

#
# Copyright:: Copyright 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefCorrectness
        # Chef Infra Client uses properties in several resources to track state. These
        # should not be set in recipes as they break the internal workings of the Chef
        # Infra Client
        #
        # @example
        #
        #   # bad
        #   service 'foo' do
        #     running true
        #     action [:start, :enable]
        #   end
        #
        #   # good
        #   service 'foo' do
        #     action [:start, :enable]
        #   end
        #
        class ResourceSetsInternalProperties < Cop
          include RuboCop::Chef::CookbookHelpers

          MSG = 'Do not set properties used internally by Chef Infra Client to track the system state.'.freeze

          def on_block(node)
            match_property_in_resource?(:service, 'running', node) do |prop|
              add_offense(prop, location: :expression, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

36 entries across 36 versions & 1 rubygems

Version Path
cookstyle-6.11.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.10.2 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.9.0 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.8.0 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.7.3 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.6.9 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.5.3 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.4.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.23.0 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.3.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.2.9 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.2.5 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.1.6 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.0.19 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.22.6 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.21.9 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.20.0 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.19.9 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.18.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-5.17.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb