Sha256: 3a2e07d2d9c85691d6b642532626c03798cbd7e82f716c79b562208fefb7820a

Contents?: true

Size: 1006 Bytes

Versions: 38

Compression:

Stored size: 1006 Bytes

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for `rescue` blocks targeting the Exception class.
      #
      # @example
      #
      #   # bad
      #
      #   begin
      #     do_something
      #   rescue Exception
      #     handle_exception
      #   end
      #
      # @example
      #
      #   # good
      #
      #   begin
      #     do_something
      #   rescue ArgumentError
      #     handle_exception
      #   end
      class RescueException < Base
        MSG = 'Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`?'

        def on_resbody(node)
          return unless node.children.first

          rescue_args = node.children.first.children
          return unless rescue_args.any? { |a| targets_exception?(a) }

          add_offense(node)
        end

        def targets_exception?(rescue_arg_node)
          rescue_arg_node.const_name == 'Exception'
        end
      end
    end
  end
end

Version data entries

38 entries across 38 versions & 6 rubygems

Version Path
scrapbook-0.3.2 vendor/ruby/2.7.0/gems/rubocop-1.26.0/lib/rubocop/cop/lint/rescue_exception.rb
scrapbook-0.3.1 vendor/ruby/2.7.0/gems/rubocop-1.26.0/lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.29.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.29.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.28.2 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.28.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.28.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.27.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.26.1 lib/rubocop/cop/lint/rescue_exception.rb
op_connect-0.1.2 vendor/bundle/ruby/3.1.0/gems/rubocop-1.26.0/lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.26.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.25.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.25.0 lib/rubocop/cop/lint/rescue_exception.rb
phillipug-foodie-0.1.0 .vendor/ruby/3.0.0/gems/rubocop-1.24.0/lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.24.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.24.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.23.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.22.3 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.22.2 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-1.22.1 lib/rubocop/cop/lint/rescue_exception.rb