Sha256: 38cace9682fd0293cdaf5f74edf975139b4445eaa4850ab76833dd6384b4f7df
Contents?: true
Size: 1.29 KB
Versions: 7
Compression:
Stored size: 1.29 KB
Contents
# frozen_string_literal: true
module RailsBestPractices
module Reviews
# Review a controller file to make sure using simplified syntax for render.
#
# See the best practice details here https://rails-bestpractices.com/posts/2010/12/12/simplify-render-in-controllers/
#
# Implementation:
#
# Review process:
# check all render method commands in controller files,
# if there is a key 'action', 'template' or 'file' in the argument,
# then they should be replaced by simplified syntax.
class SimplifyRenderInControllersReview < Review
interesting_nodes :command
interesting_files CONTROLLER_FILES
url 'https://rails-bestpractices.com/posts/2010/12/12/simplify-render-in-controllers/'
# check command node in the controller file,
# if its message is render and the arguments contain a key action, template or file,
# then it should be replaced by simplified syntax.
add_callback :start_command do |node|
if node.message.to_s == 'render'
keys = node.arguments.all.first.hash_keys
if keys && keys.size == 1 && (keys.include?('action') || keys.include?('template') || keys.include?('file'))
add_error 'simplify render in controllers'
end
end
end
end
end
end
Version data entries
7 entries across 7 versions & 1 rubygems