require 'brakeman/checks/base_check' require 'set' #Checks for mass assignments to models. # #See http://guides.rubyonrails.org/security.html#mass-assignment for details class Brakeman::CheckMassAssignment < Brakeman::BaseCheck Brakeman::Checks.add self @description = "Finds instances of mass assignment" def run_check return if mass_assign_disabled? models = [] tracker.models.each do |name, m| if parent?(m, :"ActiveRecord::Base") and m[:attr_accessible].nil? models << name end end return if models.empty? @results = Set.new Brakeman.debug "Finding possible mass assignment calls on #{models.length} models" calls = tracker.find_call :chained => true, :targets => models, :methods => [:new, :attributes=, :update_attribute, :update_attributes, :update_attributes!, :create, :create!, :build] Brakeman.debug "Processing possible mass assignment calls" calls.each do |result| process_result result end end #All results should be Model.new(...) or Model.attributes=() calls def process_result res call = res[:call] check = check_call call if check and not @results.include? call @results << call model = tracker.models[res[:chain].first] attr_protected = (model and model[:options][:attr_protected]) if attr_protected and tracker.options[:ignore_attr_protected] return elsif include_user_input? call[3] and not hash? call[3][1] and not attr_protected confidence = CONFIDENCE[:high] else confidence = CONFIDENCE[:low] end warn :result => res, :warning_type => "Mass Assignment", :message => "Unprotected mass assignment", :line => call.line, :code => call, :confidence => confidence end res end #Want to ignore calls to Model.new that have no arguments def check_call call args = process call[3] if args.length <= 1 #empty new() false elsif hash? args[1] and not include_user_input? args[1] false elsif all_literals? args false else true end end LITERALS = Set[:lit, :true, :false, :nil, :string] def all_literals? args args.all? do |arg| if sexp? arg if arg.node_type == :hash all_literals? arg else LITERALS.include? arg.node_type end else true end end end end