Sha256: 350401287e8c284feeff28544e98b422bf818c69ebf52878edb4071b0ffc2431

Contents?: true

Size: 1.67 KB

Versions: 6

Compression:

Stored size: 1.67 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Rails
      # This cop checks whether the migration implements
      # either a `change` method or both an `up` and a `down`
      # method.
      #
      # @example
      #   # bad
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def up
      #       # up migration
      #     end
      #
      #     # <----- missing down method
      #   end
      #
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     # <----- missing up method
      #
      #     def down
      #       # down migration
      #     end
      #   end
      #
      #   # good
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def change
      #       # reversible migration
      #     end
      #   end
      #
      #   # good
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def up
      #       # up migration
      #     end
      #
      #     def down
      #       # down migration
      #     end
      #   end
      class ReversibleMigrationMethodDefinition < Base
        include MigrationsHelper

        MSG = 'Migrations must contain either a `change` method, or ' \
              'both an `up` and a `down` method.'

        def_node_matcher :change_method?, <<~PATTERN
          [ #migration_class? `(def :change (args) _) ]
        PATTERN

        def_node_matcher :up_and_down_methods?, <<~PATTERN
          [ #migration_class? `(def :up (args) _) `(def :down (args) _) ]
        PATTERN

        def on_class(node)
          return if change_method?(node) || up_and_down_methods?(node)

          add_offense(node)
        end
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 2 rubygems

Version Path
scrapbook-0.3.2 vendor/ruby/2.7.0/gems/rubocop-rails-2.14.2/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
scrapbook-0.3.1 vendor/ruby/2.7.0/gems/rubocop-rails-2.14.2/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.14.2 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.14.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.14.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.13.2 lib/rubocop/cop/rails/reversible_migration_method_definition.rb