Contents

# frozen_string_literal: true
require_relative 'smell_detector'
require_relative 'smell_warning'

module Reek
  module Smells
    #
    # A Large Class is a class or module that has a large number of
    # instance variables, methods, constants or lines of code.
    #
    # +TooManyConstants' reports classes having more than a
    # configurable number of constants.
    #
    # See {file:docs/Too-Many-Constants.md} for details.
    class TooManyConstants < SmellDetector
      # The name of the config field that sets the maximum number
      # of constants permitted in a class.
      MAX_ALLOWED_CONSTANTS_KEY = 'max_constants'.freeze
      DEFAULT_MAX_CONSTANTS = 5
      IGNORED_NODES = [:module, :class].freeze

      def self.contexts
        [:class, :module]
      end

      def self.default_config
        super.merge(
          MAX_ALLOWED_CONSTANTS_KEY => DEFAULT_MAX_CONSTANTS,
          EXCLUDE_KEY => [])
      end

      #
      # Checks +klass+ for too many constants.
      #
      # @return [Array<SmellWarning>]
      #
      def sniff(ctx)
        max_allowed_constants = value(MAX_ALLOWED_CONSTANTS_KEY, ctx)

        count = ctx.each_node(:casgn, IGNORED_NODES).delete_if(&:defines_module?).length

        return [] if count <= max_allowed_constants

        build_smell_warning(ctx, count)
      end

      private

      def build_smell_warning(ctx, count)
        [smell_warning(
          context: ctx,
          lines: [ctx.exp.line],
          message: "has #{count} constants",
          parameters: { count: count })]
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version	Path
reek-4.4.2	lib/reek/smells/too_many_constants.rb
reek-4.4.1	lib/reek/smells/too_many_constants.rb
reek-4.4.0	lib/reek/smells/too_many_constants.rb
reek-4.3.0	lib/reek/smells/too_many_constants.rb
reek-4.2.5	lib/reek/smells/too_many_constants.rb
reek-4.2.4	lib/reek/smells/too_many_constants.rb