Sha256: 2f2cfcb77f442241b60a4829223239460c237da810b4daedeaa3da39693349a1
Contents?: true
Size: 1.88 KB
Versions: 8
Compression:
Stored size: 1.88 KB
Contents
#
# Copyright:: Copyright 2019, Chef Software Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
module Cop
module Chef
module ChefDeprecations
# The node.set_unless method has been removed in Chef Infra Client 13 and usage must be replaced with node.normal_unless.
#
# This cop will autocorrect code to use node.normal_unless, which is functionally identical to node.set_unless, but we also discourage the use of that method as normal level attributes persist on the node even if the code setting the attribute is later removed.
#
# @example
#
# # bad
# node.set_unless['foo'] = true
#
# # good
# node.normal_unless['foo'] = true
#
class NodeSetUnless < Cop
MSG = 'Do not use node.set_unless. Replace with node.normal_unless to keep identical behavior.'.freeze
def_node_matcher :node_set_unless?, <<-PATTERN
(send (send _ :node) $:set_unless)
PATTERN
def on_send(node)
node_set_unless?(node) do
add_offense(node, location: :selector, message: MSG, severity: :warning)
end
end
def autocorrect(node)
lambda do |corrector|
corrector.replace(node.loc.selector, 'normal_unless')
end
end
end
end
end
end
end
Version data entries
8 entries across 8 versions & 1 rubygems