# frozen_string_literal: true module RuboCop module Cop module Performance # This cop identifies unnecessary use of a regex where `String#end_with?` would suffice. # # This cop has `SafeMultiline` configuration option that `true` by default because # `end$` is unsafe as it will behave incompatible with `end_with?` # for receiver is multiline string. # # @example # # bad # 'abc'.match?(/bc\Z/) # /bc\Z/.match?('abc') # 'abc' =~ /bc\Z/ # /bc\Z/ =~ 'abc' # 'abc'.match(/bc\Z/) # /bc\Z/.match('abc') # # # good # 'abc'.end_with?('bc') # # @example SafeMultiline: true (default) # # # good # 'abc'.match?(/bc$/) # /bc$/.match?('abc') # 'abc' =~ /bc$/ # /bc$/ =~ 'abc' # 'abc'.match(/bc$/) # /bc$/.match('abc') # # @example SafeMultiline: false # # # bad # 'abc'.match?(/bc$/) # /bc$/.match?('abc') # 'abc' =~ /bc$/ # /bc$/ =~ 'abc' # 'abc'.match(/bc$/) # /bc$/.match('abc') # class EndWith < Cop include RegexpMetacharacter MSG = 'Use `String#end_with?` instead of a regex match anchored to ' \ 'the end of the string.' def_node_matcher :redundant_regex?, <<~PATTERN {(send $!nil? {:match :=~ :match?} (regexp (str $#literal_at_end?) (regopt))) (send (regexp (str $#literal_at_end?) (regopt)) {:match :match?} $_) (match-with-lvasgn (regexp (str $#literal_at_end?) (regopt)) $_)} PATTERN def on_send(node) return unless redundant_regex?(node) add_offense(node) end alias on_match_with_lvasgn on_send def autocorrect(node) redundant_regex?(node) do |receiver, regex_str| receiver, regex_str = regex_str, receiver if receiver.is_a?(String) regex_str = drop_end_metacharacter(regex_str) regex_str = interpret_string_escapes(regex_str) lambda do |corrector| new_source = receiver.source + '.end_with?(' + to_string_literal(regex_str) + ')' corrector.replace(node.source_range, new_source) end end end end end end end