Sha256: 22a21e730248563c6f5b64a4701ccadba5c7f8782807b4256ad50d8029f97d4f

Contents?: true

Size: 1.14 KB

Versions: 96

Compression:

Stored size: 1.14 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Performance
      # Identifies places where `sort { |a, b| a <=> b }` can be replaced with `sort`.
      #
      # @example
      #   # bad
      #   array.sort { |a, b| a <=> b }
      #
      #   # good
      #   array.sort
      #
      class RedundantSortBlock < Base
        include SortBlock
        extend AutoCorrector

        MSG = 'Use `sort` without block.'

        def on_block(node)
          return unless (send, var_a, var_b, body = sort_with_block?(node))

          replaceable_body?(body, var_a, var_b) do
            register_offense(send, node)
          end
        end

        def on_numblock(node)
          return unless (send, arg_count, body = sort_with_numblock?(node))
          return unless arg_count == 2

          replaceable_body?(body, :_1, :_2) do
            register_offense(send, node)
          end
        end

        private

        def register_offense(send, node)
          range = sort_range(send, node)

          add_offense(range) do |corrector|
            corrector.replace(range, 'sort')
          end
        end
      end
    end
  end
end

Version data entries

96 entries across 96 versions & 6 rubygems

Version Path
rubocop-performance-1.23.1 lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.23.0 lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.22.1 lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.22.0 lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.21.1 lib/rubocop/cop/performance/redundant_sort_block.rb
katalyst-govuk-formbuilder-1.9.2 vendor/bundle/ruby/3.3.0/gems/rubocop-performance-1.21.0/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-2.8.1 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.21.0 lib/rubocop/cop/performance/redundant_sort_block.rb
mlh-rubocop-config-1.0.3 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.20.2/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.10 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
rubocop-performance-1.20.2 lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.9 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.8 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.7 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.6 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.5 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.4 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.3 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.2 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb
harbr-0.2.1 vendor/bundle/ruby/3.2.0/gems/rubocop-performance-1.19.1/lib/rubocop/cop/performance/redundant_sort_block.rb