Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks that there are no repeated conditions
      # used in case 'when' expressions.
      #
      # @example
      #
      #   # bad
      #
      #   case x
      #   when 'first'
      #     do_something
      #   when 'first'
      #     do_something_else
      #   end
      #
      # @example
      #
      #   # good
      #
      #   case x
      #   when 'first'
      #     do_something
      #   when 'second'
      #     do_something_else
      #   end
      class DuplicateCaseCondition < Cop
        MSG = 'Duplicate `when` condition detected.'.freeze

        def on_case(case_node)
          case_node.when_branches.each_with_object([]) do |when_node, previous|
            when_node.each_condition do |condition|
              if repeated_condition?(previous, condition)
                add_offense(condition, :expression, MSG)
              end
            end

            previous.push(when_node.conditions)
          end
        end

        private

        def repeated_condition?(previous, condition)
          previous.any? { |c| c.include?(condition) }
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rubocop-0.49.1	lib/rubocop/cop/lint/duplicate_case_condition.rb
rubocop-0.49.0	lib/rubocop/cop/lint/duplicate_case_condition.rb
rubocop-0.48.1	lib/rubocop/cop/lint/duplicate_case_condition.rb
rubocop-0.48.0	lib/rubocop/cop/lint/duplicate_case_condition.rb