# frozen_string_literal: true # # Copyright:: 2019, Chef Software Inc. # Author:: Tim Smith () # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # module RuboCop module Cop module Chef module ChefModernize # The allowed actions can now be specified using the `allowed_actions` helper instead of using the @actions or @allowed_actions variables in the resource's initialize method. In general we recommend against writing HWRPs, but if HWRPs are necessary you should utilize as much of the resource DSL as possible. # # @example # # # bad # def initialize(*args) # super # @actions = [ :create, :add ] # end # # # also bad # def initialize(*args) # super # @allowed_actions = [ :create, :add ] # end # # # good # allowed_actions [ :create, :add ] # class AllowedActionsFromInitialize < Cop include RangeHelp MSG = 'The allowed actions of a resource can be set with the "allowed_actions" helper instead of using the initialize method.' def on_def(node) return unless node.method_name == :initialize return if node.body.nil? # nil body is an empty initialize method node.body.each_node do |x| if x.assignment? && !x.parent.op_asgn_type? && !x.node_parts.empty? && %i(@actions @allowed_actions).include?(x.node_parts.first) add_offense(x, location: :expression, message: MSG, severity: :refactor) end end end def_node_search :action_methods?, '(send nil? {:actions :allowed_actions} ... )' def_node_search :initialize_method, '(def :initialize ... )' def autocorrect(node) lambda do |corrector| # insert the new allowed_actions call above the initialize method, but not if one already exists (this is sadly common) unless action_methods?(processed_source.ast) initialize_node = initialize_method(processed_source.ast).first corrector.insert_before(initialize_node.source_range, "allowed_actions #{node.descendants.first.source}\n\n") end # remove the variable from the initialize method corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left)) end end end end end end end