Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Minitest
      # Common functionality for `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops.
      module PredicateAssertionHandleable
        MSG = 'Prefer using `%<assertion_type>s_predicate(%<new_arguments>s)`.'
        RESTRICT_ON_SEND = %i[assert].freeze

        def on_send(node)
          return unless (arguments = peel_redundant_parentheses_from(node.arguments))
          return unless arguments.first.respond_to?(:predicate_method?) && arguments.first.predicate_method?
          return unless arguments.first.arguments.count.zero?

          add_offense(node, message: offense_message(arguments)) do |corrector|
            autocorrect(corrector, node, arguments)
          end
        end

        def autocorrect(corrector, node, arguments)
          corrector.replace(node.loc.selector, "#{assertion_type}_predicate")

          new_arguments = new_arguments(arguments).join(', ')

          corrector.replace(first_argument_range(node), new_arguments)
        end

        private

        def peel_redundant_parentheses_from(arguments)
          return arguments unless arguments.first&.begin_type?

          peel_redundant_parentheses_from(arguments.first.children)
        end

        def offense_message(arguments)
          message_argument = arguments.last if arguments.first != arguments.last

          new_arguments = [
            new_arguments(arguments),
            message_argument&.source
          ].flatten.compact.join(', ')

          format(MSG, assertion_type: assertion_type, new_arguments: new_arguments)
        end

        def new_arguments(arguments)
          receiver = correct_receiver(arguments.first.receiver)
          method_name = arguments.first.method_name

          [receiver, ":#{method_name}"]
        end

        def correct_receiver(receiver)
          receiver ? receiver.source : 'self'
        end
      end
    end
  end
end

Version data entries

3 entries across 3 versions & 1 rubygems

Version	Path
rubocop-minitest-0.19.1	lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
rubocop-minitest-0.19.0	lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
rubocop-minitest-0.18.0	lib/rubocop/cop/mixin/predicate_assertion_handleable.rb