Sha256: 1d6706ba185abb6d9ee6899d911505c6b7144e0db4bb007ad91e746951eb38b8
Contents?: true
Size: 1.62 KB
Versions: 55
Compression:
Stored size: 1.62 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module InternalAffairs
# Enforces the use of `same_line?` instead of location line comparison for equality.
#
# @example
# # bad
# node.loc.line == node.parent.loc.line
#
# # bad
# node.loc.first_line == node.parent.loc.first_line
#
# # good
# same_line?(node, node.parent)
#
class LocationLineEqualityComparison < Base
extend AutoCorrector
MSG = 'Use `%<preferred>s`.'
# @!method line_send(node)
def_node_matcher :line_send, <<~PATTERN
{
(send (send _ {:loc :source_range}) {:line :first_line})
(send _ :first_line)
}
PATTERN
# @!method location_line_equality_comparison?(node)
def_node_matcher :location_line_equality_comparison?, <<~PATTERN
(send #line_send :== #line_send)
PATTERN
def on_send(node)
return unless location_line_equality_comparison?(node)
lhs, _op, rhs = *node
lhs_receiver = extract_receiver(lhs)
rhs_receiver = extract_receiver(rhs)
preferred = "same_line?(#{lhs_receiver}, #{rhs_receiver})"
add_offense(node, message: format(MSG, preferred: preferred)) do |corrector|
corrector.replace(node, preferred)
end
end
private
def extract_receiver(node)
receiver = node.receiver
receiver = receiver.receiver if receiver.method?(:loc) || receiver.method?(:source_range)
receiver.source
end
end
end
end
end
Version data entries
55 entries across 49 versions & 7 rubygems