Sha256: 1bc8d01886f0fe11627c058288fc037cb24891917b75bcc0247a2bc13c2dbf34
Contents?: true
Size: 1.8 KB
Versions: 11
Compression:
Stored size: 1.8 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for expressions where there is a call to a predicate
# method with at least one argument, where no parentheses are used around
# the parameter list, and a boolean operator, && or ||, is used in the
# last argument.
#
# The idea behind warning for these constructs is that the user might
# be under the impression that the return value from the method call is
# an operand of &&/||.
#
# @example
#
# if day.is? :tuesday && month == :jan
# ...
# end
class RequireParentheses < Cop
include IfNode
MSG = 'Use parentheses in the method call to avoid confusion about ' \
'precedence.'.freeze
def on_send(node)
_receiver, method_name, *args = *node
return if parentheses?(node)
return if args.empty?
if ternary?(args.first)
check_ternary(args.first, node)
elsif predicate?(method_name)
# We're only checking predicate methods. There would be false
# positives otherwise.
check_send(args.last, node)
end
end
private
def check_ternary(arg, node)
condition, = *arg
return unless offense?(condition)
expr = node.source_range
range = range_between(expr.begin_pos, condition.source_range.end_pos)
add_offense(range, range)
end
def check_send(arg, node)
add_offense(node, :expression) if offense?(arg)
end
def predicate?(method_name)
method_name.to_s.end_with?('?')
end
def offense?(node)
[:and, :or].include?(node.type)
end
end
end
end
end
Version data entries
11 entries across 11 versions & 2 rubygems