Sha256: 1bbe3318948c47970ef9b9fc3808dbb9d492130f737fad2630f403f19d18ab2c

Contents?: true

Size: 1 KB

Versions: 11

Compression:

Stored size: 1 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for `rescue` blocks targeting the Exception class.
      #
      # @example
      #
      #   # bad
      #
      #   begin
      #     do_something
      #   rescue Exception
      #     handle_exception
      #   end
      #
      # @example
      #
      #   # good
      #
      #   begin
      #     do_something
      #   rescue ArgumentError
      #     handle_exception
      #   end
      class RescueException < Cop
        MSG = 'Avoid rescuing the `Exception` class. ' \
              'Perhaps you meant to rescue `StandardError`?'

        def on_resbody(node)
          return unless node.children.first

          rescue_args = node.children.first.children
          return unless rescue_args.any? { |a| targets_exception?(a) }

          add_offense(node)
        end

        def targets_exception?(rescue_arg_node)
          rescue_arg_node.const_name == 'Exception'
        end
      end
    end
  end
end

Version data entries

11 entries across 11 versions & 3 rubygems

Version Path
rubocop-0.88.0 lib/rubocop/cop/lint/rescue_exception.rb
rbhint-0.87.1.rc1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.87.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.87.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.86.0 lib/rubocop/cop/lint/rescue_exception.rb
files.com-1.0.1 vendor/bundle/ruby/2.5.0/gems/rubocop-0.85.1/lib/rubocop/cop/lint/rescue_exception.rb
rbhint-0.85.1.rc2 lib/rubocop/cop/lint/rescue_exception.rb
rbhint-0.85.1.rc1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.85.1 lib/rubocop/cop/lint/rescue_exception.rb
rbhint-0.8.5.rc1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.85.0 lib/rubocop/cop/lint/rescue_exception.rb