Sha256: 1b61e34c29015cfafdd458680637ac1e9f3fb5233cc5ad45ce1c2fdcf647cb8a

Contents?: true

Size: 1.28 KB

Versions: 186

Compression:

Stored size: 1.28 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # Checks for mistyped shorthand assignments.
      #
      # @example
      #   # bad
      #   x =- y
      #   x =+ y
      #   x =* y
      #   x =! y
      #
      #   # good
      #   x -= y # or x = -y
      #   x += y # or x = +y
      #   x *= y # or x = *y
      #   x != y # or x = !y
      #
      class AmbiguousAssignment < Base
        include RangeHelp

        MSG = 'Suspicious assignment detected. Did you mean `%<op>s`?'

        SIMPLE_ASSIGNMENT_TYPES = %i[lvasgn ivasgn cvasgn gvasgn casgn].freeze

        MISTAKES = { '=-' => '-=', '=+' => '+=', '=*' => '*=', '=!' => '!=' }.freeze

        def on_asgn(node)
          return unless (rhs = rhs(node))

          range = range_between(node.loc.operator.end_pos - 1, rhs.source_range.begin_pos + 1)
          source = range.source
          return unless MISTAKES.key?(source)

          add_offense(range, message: format(MSG, op: MISTAKES[source]))
        end

        SIMPLE_ASSIGNMENT_TYPES.each { |asgn_type| alias_method :"on_#{asgn_type}", :on_asgn }

        private

        def rhs(node)
          if node.casgn_type?
            node.children[2]
          else
            node.children[1]
          end
        end
      end
    end
  end
end

Version data entries

186 entries across 179 versions & 17 rubygems

Version Path
rubocop-1.68.0 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.67.0 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.66.1 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.66.0 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.65.1 lib/rubocop/cop/lint/ambiguous_assignment.rb
blacklight-spotlight-3.6.0.beta8 vendor/bundle/ruby/3.2.0/gems/rubocop-1.64.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.65.0 lib/rubocop/cop/lint/ambiguous_assignment.rb
cm-admin-1.5.22 vendor/bundle/ruby/3.3.0/gems/rubocop-1.35.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
cm-admin-1.5.21 vendor/bundle/ruby/3.3.0/gems/rubocop-1.35.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
cm-admin-1.5.20 vendor/bundle/ruby/3.3.0/gems/rubocop-1.35.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
katalyst-govuk-formbuilder-1.9.2 vendor/bundle/ruby/3.3.0/gems/rubocop-1.64.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.64.1 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.63.4 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.63.3 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.63.2 lib/rubocop/cop/lint/ambiguous_assignment.rb
harbr-2.8.1 vendor/bundle/ruby/3.2.0/gems/rubocop-1.57.2/lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.63.1 lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.63.0 lib/rubocop/cop/lint/ambiguous_assignment.rb
bison-0.1.0 vendor/bundle/ruby/3.2.0/gems/rubocop-1.62.1/lib/rubocop/cop/lint/ambiguous_assignment.rb
rubocop-1.62.1 lib/rubocop/cop/lint/ambiguous_assignment.rb