# frozen_string_literal: true module RuboCop module Cop module Style # Checks for uses of `each_key` and `each_value` Hash methods. # # NOTE: If you have an array of two-element arrays, you can put # parentheses around the block arguments to indicate that you're not # working with a hash, and suppress RuboCop offenses. # # @safety # This cop is unsafe because it cannot be guaranteed that the receiver # is a `Hash`. The `AllowedReceivers` configuration can mitigate, # but not fully resolve, this safety issue. # # @example # # bad # hash.keys.each { |k| p k } # hash.values.each { |v| p v } # # # good # hash.each_key { |k| p k } # hash.each_value { |v| p v } # # @example AllowedReceivers: ['execute'] # # good # execute(sql).keys.each { |v| p v } # execute(sql).values.each { |v| p v } class HashEachMethods < Base include Lint::UnusedArgument extend AutoCorrector MSG = 'Use `%s` instead of `%s`.' # @!method kv_each(node) def_node_matcher :kv_each, <<~PATTERN ({block numblock} $(send (send _ ${:keys :values}) :each) ...) PATTERN # @!method kv_each_with_block_pass(node) def_node_matcher :kv_each_with_block_pass, <<~PATTERN (send $(send _ ${:keys :values}) :each (block_pass (sym _))) PATTERN def on_block(node) kv_each(node) do |target, method| register_kv_offense(target, method) end end alias on_numblock on_block def on_block_pass(node) kv_each_with_block_pass(node.parent) do |target, method| register_kv_with_block_pass_offense(node, target, method) end end private def register_kv_offense(target, method) return unless (parent_receiver = target.receiver.receiver) return if allowed_receiver?(parent_receiver) add_offense(kv_range(target), message: format_message(method)) do |corrector| correct_key_value_each(target, corrector) end end def register_kv_with_block_pass_offense(node, target, method) return unless (parent_receiver = node.parent.receiver.receiver) return if allowed_receiver?(parent_receiver) range = target.loc.selector.with(end_pos: node.parent.loc.selector.end_pos) add_offense(range, message: format_message(method)) do |corrector| corrector.replace(range, "each_#{method[0..-2]}") end end def format_message(method_name) format(MSG, prefer: "each_#{method_name[0..-2]}", current: "#{method_name}.each") end def check_argument(variable) return unless variable.block_argument? (@block_args ||= []).push(variable) end def used?(arg) @block_args.find { |var| var.declaration_node.loc == arg.loc }.used? end def correct_implicit(node, corrector, method_name) corrector.replace(node, method_name) correct_args(node, corrector) end def correct_key_value_each(node, corrector) receiver = node.receiver.receiver name = "each_#{node.receiver.method_name.to_s.chop}" return correct_implicit(node, corrector, name) unless receiver new_source = receiver.source + ".#{name}" corrector.replace(node, new_source) end def correct_args(node, corrector) args = node.parent.arguments name, = *args.children.find { |arg| used?(arg) } corrector.replace(args, "|#{name}|") end def kv_range(outer_node) outer_node.receiver.loc.selector.join(outer_node.loc.selector) end def allowed_receiver?(receiver) receiver_name = receiver_name(receiver) allowed_receivers.include?(receiver_name) end def receiver_name(receiver) if receiver.send_type? if receiver.receiver "#{receiver_name(receiver.receiver)}.#{receiver.method_name}" else receiver.method_name.to_s end else receiver.source end end def allowed_receivers cop_config.fetch('AllowedReceivers', []) end end end end end