Contents

require 'reek/smells/smell_detector'
require 'reek/smell_warning'

module Reek
  module Smells

    #
    # A Long Parameter List occurs when a method has more than one
    # or two parameters, or when a method yields more than one or
    # two objects to an associated block.
    #
    # Currently +LongParameterList+ reports any method or block with too
    # many parameters.
    #
    class LongParameterList < SmellDetector

      # The name of the config field that sets the maximum number of
      # parameters permitted in any method or block.
      MAX_ALLOWED_PARAMS_KEY = 'max_params'

      def self.default_config
        super.adopt(MAX_ALLOWED_PARAMS_KEY => 3)
      end

      def initialize(config = LongParameterList.default_config)
        super(config)
        @action = 'has'
      end

      #
      # Checks the number of parameters in the given scope.
      # Remembers any smells found.
      #
      def examine_context(ctx)
        num_params = ctx.parameters.length
        return false if num_params <= @config['max_params']
        found(ctx, "#{@action} #{num_params} parameters")
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version	Path
kevinrutherford-reek-1.1.3.10	lib/reek/smells/long_parameter_list.rb
kevinrutherford-reek-1.1.3.11	lib/reek/smells/long_parameter_list.rb
kevinrutherford-reek-1.1.3.12	lib/reek/smells/long_parameter_list.rb
kevinrutherford-reek-1.1.3.13	lib/reek/smells/long_parameter_list.rb
kevinrutherford-reek-1.1.3.8	lib/reek/smells/long_parameter_list.rb
kevinrutherford-reek-1.1.3.9	lib/reek/smells/long_parameter_list.rb