require 'spec_helper' describe Danger::Changelog::ChangelogFile do subject do Danger::Changelog::ChangelogFile.new(filename).tap(&:parse) end describe 'with the default format checker' do context 'minimal example' do let(:filename) { File.expand_path('fixtures/minimal.md', __dir__) } it 'exists?' do expect(subject.exists?).to be true end it 'bad_lines?' do expect(subject.bad_lines).to eq [] expect(subject.bad_lines?).to be false end it 'is valid' do expect(subject.bad_lines?).to be false end it 'has your contribution here' do expect(subject.global_failures?).to be false end end context 'missing your contribution here' do let(:filename) { File.expand_path('fixtures/missing_your_contribution_here.md', __dir__) } it 'is valid' do expect(subject.bad_lines?).to be false end it 'is missing your contribution here' do expect(subject.global_failures?).to be true end end context 'does not exist' do let(:filename) { 'whatever.md' } it 'exists?' do expect(subject.exists?).to be false end it 'bad_lines?' do expect(subject.bad_lines).to be_empty expect(subject.bad_lines?).to be false end end context 'with bad lines' do let(:filename) { File.expand_path('fixtures/lines.md', __dir__) } it 'is invalid' do expect(subject.bad_lines?).to be true end it 'reports all bad lines' do expect(subject.bad_lines).to eq [ ["Missing star - [@dblock](https://github.com/dblock).\n", 'does not start with a star, does not include a pull request link'], ["* [#1](https://github.com/dblock/danger-changelog/pull/1) - Not a colon - [@dblock](https://github.com/dblock).\n"], ["* [#1](https://github.com/dblock/danger-changelog/pull/1): No final period - [@dblock](https://github.com/dblock)\n", 'is missing a period at the end of the line'], ["# [#1](https://github.com/dblock/danger-changelog/pull/1): Hash instead of star - [@dblock](https://github.com/dblock).\n", 'does not start with a star'], ["* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra period. - [@dblock](https://github.com/dblock).\n", 'has an extra period or comma at the end of the description'], ["* [#1](https://github.com/dblock/danger-changelog/pull/1): Unbalanced ( - [@dblock](https://github.com/dblock).\n", 'too many parenthesis'], ["* [#1](https://github.com/dblock/danger-changelog/pull/1): Unbalanced ] - [@dblock](https://github.com/dblock).\n", 'too many parenthesis'] ] end it 'has your contribution here' do expect(subject.global_failures?).to be false end end context 'with a line that has an extra trailing space' do let(:filename) { File.expand_path('fixtures/extra_trailing_space.md', __dir__) } it 'is invalid' do expect(subject.bad_lines?).to be true end it 'reports all bad lines' do expect(subject.bad_lines).to eq [ ["* [#1](https://github.com/dblock/danger-changelog/pull/1): Extra trailing space - [@dblock](https://github.com/dblock). \n", 'has an extra trailing space, is missing a period at the end of the line'] ] end end context 'with bad dates' do let(:filename) { File.expand_path('fixtures/dates.md', __dir__) } it 'is invalid' do expect(subject.bad_lines?).to be true end it 'reports all bad dates' do expect(subject.bad_lines).to eq [ ["### 1.2.3 (1/2/2018)\n"], ["### 1.2.3 (2018/13/1)\n"], ["### 1.2.3 (2018/13)\n"], ["### 1.2.3 (2018/1/1/3)\n"] ] end end context 'with bad semver' do let(:filename) { File.expand_path('fixtures/semver.md', __dir__) } it 'is invalid' do expect(subject.bad_lines?).to be true end it 'reports all bad dates' do expect(subject.bad_lines).to eq [ ["### 0 (2018/1/1)\n"], ["### 0. (2018/1/1)\n"], ["### 0.1. (2018/1/1)\n"] ] end end context 'with imbalanced parenthesis' do let(:filename) { File.expand_path('fixtures/imbalanced.md', __dir__) } it 'is invalid' do expect(subject.bad_lines?).to be true end it 'reports all bad lines' do expect(subject.bad_lines).to eq [ ["### 0.0.0)\n"], ["### (0.0.1\n"], ["### 1.2.3 (2018/1/1\n"], ["### 0.1.0 2018/1/1)\n"], ["### 0 ((2018/1/1)\n"], ["### 0. [2018/1/1)\n"], ["### 0.1. (2018/1/1)]\n"] ] end end end end