Contents

require_relative '../../spec_helper'
require_relative '../../../lib/reek/smells/uncommunicative_method_name'
require_relative 'smell_detector_shared'

RSpec.describe Reek::Smells::UncommunicativeMethodName do
  let(:source_name) { 'dummy_source' }
  let(:detector) do
    build(:smell_detector, smell_type: :UncommunicativeMethodName, source: source_name)
  end

  it_should_behave_like 'SmellDetector'

  ['help', '+', '-', '/', '*'].each do |method_name|
    it "accepts the method name '#{method_name}'" do
      src = "def #{method_name}(fred) basics(17) end"
      expect(src).not_to reek_of(:UncommunicativeMethodName)
    end
  end

  ['x', 'x2', 'method2'].each do |method_name|
    context 'with a bad name' do
      let(:warning) do
        src = "def #{method_name}; end"
        ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
        detector.examine_context(ctx).first
      end

      it_should_behave_like 'common fields set correctly'

      it 'reports the correct values' do
        expect(warning.parameters[:name]).to eq(method_name)
        expect(warning.lines).to eq([1])
        expect(warning.context).to eq(method_name)
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
reek-3.3.1	spec/reek/smells/uncommunicative_method_name_spec.rb
reek-3.3.0	spec/reek/smells/uncommunicative_method_name_spec.rb