# frozen_string_literal: true module RuboCop module Cop module Bundler # A Gem group, or a set of groups, should be listed only once in a Gemfile. # # @example # # bad # group :development do # gem 'rubocop' # end # # group :development do # gem 'rubocop-rails' # end # # # bad (same set of groups declared twice) # group :development, :test do # gem 'rubocop' # end # # group :test, :development do # gem 'rspec' # end # # # good # group :development do # gem 'rubocop' # end # # group :development, :test do # gem 'rspec' # end # # # good # gem 'rubocop', groups: [:development, :test] # gem 'rspec', groups: [:development, :test] # class DuplicatedGroup < Base include RangeHelp MSG = 'Gem group `%s` already defined on line ' \ '%d of the Gemfile.' def on_new_investigation return if processed_source.blank? duplicated_group_nodes.each do |nodes| nodes[1..].each do |node| register_offense(node, node.arguments.map(&:value).join(', '), nodes.first.first_line) end end end private # @!method group_declarations(node) def_node_search :group_declarations, '(send nil? :group ...)' def duplicated_group_nodes group_declarations(processed_source.ast) .group_by { |node| node.arguments.map(&:value).map(&:to_s).sort } .values .select { |nodes| nodes.size > 1 } end def register_offense(node, group_name, line_of_first_occurrence) line_range = node.loc.column...node.loc.last_column offense_location = source_range(processed_source.buffer, node.first_line, line_range) message = format( MSG, group_name: group_name, line_of_first_occurrence: line_of_first_occurrence ) add_offense(offense_location, message: message) end end end end end