Contents

# encoding: utf-8
require 'rails_best_practices/reviews/review'

module RailsBestPractices
  module Reviews
    # Review a helper file to make sure it is not an empty moduel.
    #
    # See the best practice details here http://rails-bestpractices.com/posts/72-remove-empty-helpers.
    #
    # Implementation:
    #
    # Review process:
    #   check all helper files, if the body of module is nil, then the helper file should be removed.
    class RemoveEmptyHelpersReview < Review
      def url
        "http://rails-bestpractices.com/posts/72-remove-empty-helpers"
      end

      def interesting_files
        HELPER_FILES
      end

      def interesting_nodes
        [:module]
      end

      # check the body of module node, if it is nil, then it should be removed.
      def start_module(module_node)
        add_error "remove empty helpers" if module_node.body.is_a?(Core::Nil)
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 2 rubygems

Version	Path
rails_best_practices-0.10.1	lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-0.10.0	lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-raydog153-0.9.1	lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
rails_best_practices-0.9.0	lib/rails_best_practices/reviews/remove_empty_helpers_review.rb