Contents

require 'spec_helper'

module RailsBestPractices
  module Reviews
    describe DefaultScopeIsEvilReview do
      let(:runner) { Core::Runner.new(reviews: DefaultScopeIsEvilReview.new) }

      it "should detect default_scope with -> syntax" do
        content = <<-EOF
        class User < ActiveRecord::Base
          default_scope -> { order('created_at desc') }
        end
        EOF
        runner.review('app/models/user.rb', content)
        runner.should have(1).errors
        runner.errors[0].to_s.should == "app/models/user.rb:2 - default_scope is evil"
      end

      it "should detect default_scope with old syntax" do
        content = <<-EOF
        class User < ActiveRecord::Base
          default_scope order('created_at desc')
        end
        EOF
        runner.review('app/models/user.rb', content)
        runner.should have(1).errors
        runner.errors[0].to_s.should == "app/models/user.rb:2 - default_scope is evil"
      end

      it "should not detect default_scope" do
        content = <<-EOF
        class User < ActiveRecord::Base
          scope :default, -> { order('created_at desc') }
        end
        EOF
        runner.review('app/models/user.rb', content)
        runner.should have(0).errors
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version	Path
rails_best_practices-1.14.4	spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
rails_best_practices-1.14.3	spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
rails_best_practices-1.14.2	spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
rails_best_practices-1.14.1	spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb
rails_best_practices-1.14.0	spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb