Contents

#
# Copyright:: 2019, Chef Software Inc.
# Author:: Tim Smith (<[e-mail]>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      # use_inline_resources became the default in Chef Infra Client 13+ and no longer needs
      # to be called in resources
      #
      # @example
      #
      #   # bad
      #   use_inline_resources
      #   use_inline_resources if defined?(use_inline_resources)
      #
      class UseInlineResourcesDefined < Cop
        MSG = 'use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified.'.freeze

        def on_send(node)
          if node.method_name == :use_inline_resources
            # don't alert on the use_inline_resources within the defined? check
            # that would result in 2 alerts on the same line and wouldn't be useful
            return if node.parent && node.parent.defined_type?

            # catch the full offense if the method is gated like this: use_inline_resources if defined?(use_inline_resources)
            if node.parent && node.parent.if_type? && node.parent.children.first.method_name == :defined?
              node = node.parent
            end
            add_offense(node, location: :expression, message: MSG, severity: :refactor)
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            corrector.remove(node.loc.expression)
          end
        end
      end
    end
  end
end

Version data entries

1 entries across 1 versions & 1 rubygems

Version	Path
cookstyle-5.4.13	lib/rubocop/cop/chef/modernize/use_inline_resources.rb