Sha256: 11165c0701d365a6920f2f76ad17e19e211fbb2407d5ebbe6f5178cfc7da8e04

Contents?: true

Size: 1.64 KB

Versions: 33

Compression:

Stored size: 1.64 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for potential uses of `Enumerable#minmax`.
      #
      # @example
      #
      #   # bad
      #   bar = [foo.min, foo.max]
      #   return foo.min, foo.max
      #
      #   # good
      #   bar = foo.minmax
      #   return foo.minmax
      class MinMax < Base
        extend AutoCorrector

        MSG = 'Use `%<receiver>s.minmax` instead of `%<offender>s`.'

        def on_array(node)
          min_max_candidate(node) do |receiver|
            offender = offending_range(node)

            add_offense(offender, message: message(offender, receiver)) do |corrector|
              receiver = node.children.first.receiver

              corrector.replace(offending_range(node), "#{receiver.source}.minmax")
            end
          end
        end
        alias on_return on_array

        private

        def_node_matcher :min_max_candidate, <<~PATTERN
          ({array return} (send [$_receiver !nil?] :min) (send [$_receiver !nil?] :max))
        PATTERN

        def message(offender, receiver)
          format(MSG, offender: offender.source,
                      receiver: receiver.source)
        end

        def offending_range(node)
          case node.type
          when :return
            argument_range(node)
          else
            node.loc.expression
          end
        end

        def argument_range(node)
          first_argument_range = node.children.first.loc.expression
          last_argument_range  = node.children.last.loc.expression

          first_argument_range.join(last_argument_range)
        end
      end
    end
  end
end

Version data entries

33 entries across 33 versions & 3 rubygems

Version Path
plaid-14.13.0 vendor/bundle/ruby/3.0.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
plaid-14.12.1 vendor/bundle/ruby/3.0.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
plaid-14.12.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
plaid-14.11.1 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
plaid-14.10.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
plaid-14.7.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.91.1/lib/rubocop/cop/style/min_max.rb
rubocop-1.10.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.9.1 lib/rubocop/cop/style/min_max.rb
rubocop-1.9.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.8.1 lib/rubocop/cop/style/min_max.rb
rubocop-1.8.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.7.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.6.1 lib/rubocop/cop/style/min_max.rb
rubocop-1.6.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.5.2 lib/rubocop/cop/style/min_max.rb
rubocop-1.5.1 lib/rubocop/cop/style/min_max.rb
rubocop-1.5.0 lib/rubocop/cop/style/min_max.rb
rubocop-1.4.2 lib/rubocop/cop/style/min_max.rb
rubocop-1.4.1 lib/rubocop/cop/style/min_max.rb
rubocop-1.4.0 lib/rubocop/cop/style/min_max.rb