Sha256: 107dc7c43d3219096a5aeba6491c82620dfcedb71d137f67c9499c68e45efb84
Contents?: true
Size: 1.79 KB
Versions: 36
Compression:
Stored size: 1.79 KB
Contents
#
# Copyright:: 2016, Chris Henry
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
module Cop
module Chef
module ChefCorrectness
# Use a service resource to start and stop services
#
# @example when command starts a service
#
# # bad
# command "/etc/init.d/mysql start"
# command "/sbin/service/memcached start"
#
class ServiceResource < Cop
MSG = 'Use a service resource to start and stop services'.freeze
def_node_matcher :execute_command?, <<-PATTERN
(send nil? :command $str)
PATTERN
def on_send(node)
execute_command?(node) do |command|
if starts_service?(command)
add_offense(command, location: :expression, message: MSG, severity: :refactor)
end
end
end
def starts_service?(cmd)
cmd_str = cmd.to_s
(cmd_str.include?('/etc/init.d') || ['service ', '/sbin/service ',
'start ', 'stop ', 'invoke-rc.d '].any? do |service_cmd|
cmd_str.start_with?(service_cmd)
end) && %w(start stop restart reload).any? { |a| cmd_str.include?(a) }
end
end
end
end
end
end
Version data entries
36 entries across 36 versions & 1 rubygems