Sha256: 0d115aba31c5e2f82453a916898db8bc7702cd6d505f484aeaaf8677d8139e0f
Contents?: true
Size: 1.92 KB
Versions: 7
Compression:
Stored size: 1.92 KB
Contents
# frozen_string_literal: true
#
# Copyright:: 2019, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
module Cop
module Chef
module ChefStyle
# When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.
#
# @example
#
# # bad
# property :foo, [TrueClass, FalseClass]
#
# # good
# property :foo, [true, false]
#
class TrueClassFalseClassResourceProperties < Base
extend AutoCorrector
MSG = "When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass."
RESTRICT_ON_SEND = [:property, :attribute].freeze
def_node_matcher :trueclass_falseclass_property?, <<-PATTERN
(send nil? {:property :attribute} (sym _) $(array (const nil? :TrueClass) (const nil? :FalseClass)) ... )
PATTERN
def on_send(node)
trueclass_falseclass_property?(node) do |types|
add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
corrector.replace(types.loc.expression, '[true, false]')
end
end
end
end
end
end
end
end
Version data entries
7 entries across 7 versions & 1 rubygems