Sha256: 0cf0797ed095777b0698cfadba712d663e1ba94459b61c22f43b3619077a235e

Contents?: true

Size: 1.62 KB

Versions: 14

Compression:

Stored size: 1.62 KB

Contents

#
# Copyright:: 2019, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefModernize
        # Don't include the apt default recipe to update apt's package cache when you can
        # use the apt_update resource built into Chef Infra Client 12.7 and later.
        #
        # @example
        #
        #   # bad
        #   include_recipe 'apt::default'
        #   include_recipe 'apt'
        #
        #   # good
        #   apt_update
        #
        class IncludingAptDefaultRecipe < Cop
          MSG = 'Do not include the Apt default recipe to update package cache. Instead use the apt_update resource, which is built into Chef Infra Client 12.7 and later.'.freeze

          def_node_matcher :apt_recipe_usage?, <<-PATTERN
            (send nil? :include_recipe (str {"apt" "apt::default"}))
          PATTERN

          def on_send(node)
            apt_recipe_usage?(node) do
              add_offense(node, location: :expression, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

14 entries across 14 versions & 1 rubygems

Version Path
cookstyle-5.15.7 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.14.1 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.13.7 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.12.13 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.12.12 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.11.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.10.13 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.10.11 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.9.3 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.8.1 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.7.0 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.6.5 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.6.2 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
cookstyle-5.5.7 lib/rubocop/cop/chef/modernize/apt_default_recipe.rb