Sha256: 0c76359599cb86d7a0c8db3cd3e55c10e6592b970339c0091aac63d3529ac229
Contents?: true
Size: 1.05 KB
Versions: 364
Compression:
Stored size: 1.05 KB
Contents
# frozen_string_literal: true
require "rubocop"
# :nocov:
module RuboCop
module Cop
module Ariadne
# This cop ensures that tags are not set with ||=
#
# bad
# @attributes[:tag] ||= :h1
#
# good
# @attributes[:tag] = fetch_or_raise(TAG_OPTIONS, tag)
#
# good
# @attributes[:tag] = :h2
# TODO: TEST THIS
class NoTagMemoize < RuboCop::Cop::Cop
INVALID_MESSAGE = <<~STR
Avoid `[:tag] ||=`. Instead, try one of the following:
- Don't allow consumers to update the tag by having a fixed tag (e.g. `attributes[:tag] = :div`)
- Use the `fetch_or_raise` helper to only allow a tag from a restricted list.
STR
def_node_search :tag_memoized?, <<~PATTERN
(or-asgn
(send
_
_
(sym :tag)
)
_
)
PATTERN
def on_or_asgn(node)
add_offense(node, message: INVALID_MESSAGE) if tag_memoized?(node)
end
end
end
end
end
Version data entries
364 entries across 364 versions & 1 rubygems