Sha256: 0c1852f3c0b19cc909598d75c519d311b42da805620aa20fe06be345a03e920a

Contents?: true

Size: 1.17 KB

Versions: 9

Compression:

Stored size: 1.17 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module RSpec
      # This cop checks void `expect()`.
      #
      # @example
      #   # bad
      #   expect(something)
      #
      #   # good
      #   expect(something).to be(1)
      class VoidExpect < Base
        MSG = 'Do not use `expect()` without `.to` or `.not_to`. ' \
              'Chain the methods or remove it.'

        def_node_matcher :expect?, <<-PATTERN
          (send nil? :expect ...)
        PATTERN

        def_node_matcher :expect_block?, <<-PATTERN
          (block #expect? (args) _body)
        PATTERN

        def on_send(node)
          return unless expect?(node)

          check_expect(node)
        end

        def on_block(node)
          return unless expect_block?(node)

          check_expect(node)
        end

        private

        def check_expect(node)
          return unless void?(node)

          add_offense(node)
        end

        def void?(expect)
          parent = expect.parent
          return true unless parent
          return true if parent.begin_type?
          return true if parent.block_type? && parent.body == expect
        end
      end
    end
  end
end

Version data entries

9 entries across 9 versions & 1 rubygems

Version Path
rubocop-rspec-2.1.0 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-2.0.1 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-2.0.0 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-2.0.0.pre lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-1.44.1 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-1.44.0 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-1.43.2 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-1.43.1 lib/rubocop/cop/rspec/void_expect.rb
rubocop-rspec-1.43.0 lib/rubocop/cop/rspec/void_expect.rb