Sha256: 0b817ff6064dedeec8f5d9849d724fc2f34de7e81a53e45736ef325dafa543f8

Contents?: true

Size: 1.74 KB

Versions: 6

Compression:

Stored size: 1.74 KB

Contents

# frozen_string_literal: true
#
# Copyright:: 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefDeprecations
        # Don't use the dsl_name method in a resource to find the name of the resource. Use the resource_name method instead. dsl_name was removed in Chef Infra Client 13 and will now result in an error.
        #
        # @example
        #
        #   # bad
        #   my_resource = MyResource.dsl_name
        #
        #   # good
        #   my_resource = MyResource.resource_name
        #
        class ResourceUsesDslNameMethod < Cop
          MSG = 'Use resource_name instead of the dsl_name method in resources. This will cause failures in Chef Infra Client 13 and later.'

          def on_send(node)
            add_offense(node, location: :expression, message: MSG, severity: :warning) if node.method_name == :dsl_name
          end

          # potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from
          # this might not be worth it yet based on the number of these we'd run into and the false auto correct potential
        end
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version Path
cookstyle-6.15.9 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
cookstyle-6.15.5 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
cookstyle-6.15.3 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
cookstyle-6.14.7 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
cookstyle-6.13.3 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
cookstyle-6.12.6 lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb