Sha256: 09bd5a422d2ae23cea6164689a880262ef1a154b6fa7b1d2bcf3ff1a1b839f68

Contents?: true

Size: 1.91 KB

Versions: 10

Compression:

Stored size: 1.91 KB

Contents

# frozen_string_literal: true
#
# Copyright:: Copyright 2019, Chef Software Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module Deprecations
        # The node.set_unless method has been removed in Chef Infra Client 13 and usage must be replaced with node.normal_unless.
        #
        # This cop will autocorrect code to use node.normal_unless, which is functionally identical to node.set_unless, but we also discourage the use of that method as normal level attributes persist on the node even if the code setting the attribute is later removed.
        #
        # @example
        #
        #   #### incorrect
        #   node.set_unless['foo'] = true
        #
        #   #### correct
        #   node.normal_unless['foo'] = true
        #
        class NodeSetUnless < Base
          extend AutoCorrector

          MSG = 'Do not use node.set_unless. Replace with node.normal_unless to keep identical behavior.'
          RESTRICT_ON_SEND = [:set_unless].freeze

          def_node_matcher :node_set_unless?, <<-PATTERN
            (send (send _ :node) $:set_unless)
          PATTERN

          def on_send(node)
            node_set_unless?(node) do
              add_offense(node.loc.selector, severity: :warning) do |corrector|
                corrector.replace(node.loc.selector, 'normal_unless')
              end
            end
          end
        end
      end
    end
  end
end

Version data entries

10 entries across 10 versions & 1 rubygems

Version Path
cookstyle-7.32.2 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.32.1 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.32.0 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.31.9 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.31.7 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.31.3 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.31.1 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.31.0 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.30.4 lib/rubocop/cop/chef/deprecation/node_set_unless.rb
cookstyle-7.30.3 lib/rubocop/cop/chef/deprecation/node_set_unless.rb