Contents

# encoding: utf-8

module Rubocop
  module Cop
    module Style
      # This cop checks for uses of *and* and *or*.
      class AndOr < Cop
        MSG = 'Use %s instead of %s.'

        OPS = { 'and' => '&&', 'or' => '||' }

        def on_and(node)
          process_logical_op(node)
        end

        def on_or(node)
          process_logical_op(node)
        end

        private

        def process_logical_op(node)
          op = node.loc.operator.source
          op_type = node.type.to_s

          if op == op_type
            convention(node,
                       :operator,
                       sprintf(MSG, OPS[op], op))
          end
        end

        def autocorrect_action(node)
          correction = lambda do |corrector|
            replacement = (node.type == :and ? '&&' : '||')
            corrector.replace(node.loc.operator, replacement)
          end

          new_source = rewrite_node(node, correction)

          # Make the correction only if it doesn't change the AST.
          if node == SourceParser.parse(new_source).ast
            @corrections << correction
          end
        end

        def rewrite_node(node, correction)
          processed_source = SourceParser.parse(node.loc.expression.source)
          Corrector.new(processed_source.buffer, [correction]).rewrite
        end
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-0.13.1	lib/rubocop/cop/style/and_or.rb
rubocop-0.13.0	lib/rubocop/cop/style/and_or.rb