Sha256: 07cdf2c442455b5cee0c02b3ad8a81d62cab120c4b58557b366824a244665191

Contents?: true

Size: 1.9 KB

Versions: 35

Compression:

Stored size: 1.9 KB

Contents

# frozen_string_literal: true
#
# Copyright:: 2019, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module Style
        # When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.
        #
        # @example
        #
        #   #### incorrect
        #   property :foo, [TrueClass, FalseClass]
        #
        #   #### correct
        #   property :foo, [true, false]
        #
        class TrueClassFalseClassResourceProperties < Base
          extend AutoCorrector

          MSG = "When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass."
          RESTRICT_ON_SEND = [:property, :attribute].freeze

          def_node_matcher :trueclass_falseclass_property?, <<-PATTERN
            (send nil? {:property :attribute} (sym _) $(array (const nil? :TrueClass) (const nil? :FalseClass)) ... )
          PATTERN

          def on_send(node)
            trueclass_falseclass_property?(node) do |types|
              add_offense(node, message: MSG, severity: :refactor) do |corrector|
                corrector.replace(types, '[true, false]')
              end
            end
          end
        end
      end
    end
  end
end

Version data entries

35 entries across 35 versions & 1 rubygems

Version Path
cookstyle-7.30.1 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.28.2 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.27.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.26.1 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.25.10 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.25.9 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.25.8 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.25.6 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.24.1 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.23.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.22.3 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.21.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.20.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.19.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.18.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.17.0 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.16.1 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.15.4 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.15.3 lib/rubocop/cop/chef/style/true_false_resource_properties.rb
cookstyle-7.15.2 lib/rubocop/cop/chef/style/true_false_resource_properties.rb