Contents

# Warning for rescuing "Exception" or "Object".
class Wool::RescueExceptionWarning < Wool::FileWarning
  severity 5
  type :dangerous
  short_desc 'rescue Exception is dangerous'
  desc 'The line rescues "Exception" or "Object", which is too broad. Rescue StandardError instead.'
  setting_accessor :position

  def match?(file = self.body)
    find_sexps(:rescue).map do |_, types, name|
      case types[0]
      when :mrhs_new_from_args
        list = types[1] + types[2..-1]
      when Array
        list = types
      end
      list.map do |type|
        if type[0] == :var_ref &&
           type[1][0] == :@const && type[1][1] == "Exception"
          warning = RescueExceptionWarning.new(file, body, :position => type[1][2])
          warning.position[0] -= 1
          warning.line_number = type[1][2][1]
          warning
        end
      end.compact
    end.flatten
  end

  def fix
    result = ""
    all_lines = self.body.lines.to_a
    result << all_lines[0..position[0]-1].join if position[0]-1 >= 0
    result << all_lines[position[0]][0,position[1]]
    result << 'StandardError'
    if trailing = all_lines[position[0]][position[1] + 'Exception'.size .. -1]
      result << trailing
    end
    result << all_lines[position[0]+1..-1].join if position[0]+1 < all_lines.size
    result
  end
end

Version data entries

1 entries across 1 versions & 1 rubygems

Version	Path
wool-0.5.1	lib/wool/warnings/rescue_exception.rb