Sha256: 0241e985fdc3064173411cb9a0d610e3e034ae0fe97ee0dbff920279a578bc06
Contents?: true
Size: 1.82 KB
Versions: 12
Compression:
Stored size: 1.82 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop checks for .times.map calls.
# In most cases such calls can be replaced
# with an explicit array creation.
#
# @example
# # bad
# 9.times.map do |i|
# i.to_s
# end
#
# # good
# Array.new(9) do |i|
# i.to_s
# end
class TimesMap < Base
extend AutoCorrector
MESSAGE = 'Use `Array.new(%<count>s)` with a block ' \
'instead of `.times.%<map_or_collect>s`'
MESSAGE_ONLY_IF = 'only if `%<count>s` is always 0 or more'
RESTRICT_ON_SEND = %i[map collect].freeze
def on_send(node)
check(node)
end
def on_block(node)
check(node)
end
private
def check(node)
times_map_call(node) do |map_or_collect, count|
add_offense(node, message: message(map_or_collect, count)) do |corrector|
replacement = "Array.new(#{count.source}" \
"#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
corrector.replace(map_or_collect.loc.expression, replacement)
end
end
end
def message(map_or_collect, count)
template = if count.literal?
"#{MESSAGE}."
else
"#{MESSAGE} #{MESSAGE_ONLY_IF}."
end
format(template, count: count.source, map_or_collect: map_or_collect.method_name)
end
def_node_matcher :times_map_call, <<~PATTERN
{(block $(send (send $!nil? :times) {:map :collect}) ...)
$(send (send $!nil? :times) {:map :collect} (block_pass ...))}
PATTERN
end
end
end
end
Version data entries
12 entries across 12 versions & 1 rubygems