Sha256: 0169253f627643aad6b9d8a728e564b4b9960ae2cef89a5944feb613d9fdafe2

Contents?: true

Size: 1.54 KB

Versions: 28

Compression:

Stored size: 1.54 KB

Contents

# frozen_string_literal: true
#
# Copyright:: 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module Correctness
        # Use name properties instead of setting the name property in a resource. Setting the name property directly causes notification and reporting issues.
        #
        # @example
        #
        #   #### incorrect
        #   service 'foo' do
        #    name 'bar'
        #   end
        #
        #   #### correct
        #   service 'foo' do
        #    service_name 'bar'
        #   end
        #
        class ResourceSetsNameProperty < Base
          include RuboCop::Chef::CookbookHelpers

          MSG = 'Resource sets the name property in the resource instead of using a name_property.'

          def on_block(node)
            match_property_in_resource?(nil, 'name', node) do |name_node|
              add_offense(name_node, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

28 entries across 28 versions & 1 rubygems

Version Path
cookstyle-7.30.1 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.28.2 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.27.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.26.1 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.25.10 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.25.9 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.25.8 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.25.6 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.24.1 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.23.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.22.3 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.21.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.20.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.19.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.18.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.17.0 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.16.1 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.15.4 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.15.3 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
cookstyle-7.15.2 lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb