Sha256: 012ebc453c4f170eb6e730c12e689a78bf3f1acde960893cbbc649618fe0eb40

Contents?: true

Size: 1.63 KB

Versions: 44

Compression:

Stored size: 1.63 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Rails
      # Checks whether the migration implements
      # either a `change` method or both an `up` and a `down`
      # method.
      #
      # @example
      #   # bad
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def up
      #       # up migration
      #     end
      #
      #     # <----- missing down method
      #   end
      #
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     # <----- missing up method
      #
      #     def down
      #       # down migration
      #     end
      #   end
      #
      #   # good
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def change
      #       # reversible migration
      #     end
      #   end
      #
      #   # good
      #   class SomeMigration < ActiveRecord::Migration[6.0]
      #     def up
      #       # up migration
      #     end
      #
      #     def down
      #       # down migration
      #     end
      #   end
      class ReversibleMigrationMethodDefinition < Base
        include MigrationsHelper

        MSG = 'Migrations must contain either a `change` method, or both an `up` and a `down` method.'

        def_node_matcher :change_method?, <<~PATTERN
          `(def :change (args) _)
        PATTERN

        def_node_matcher :up_and_down_methods?, <<~PATTERN
          [`(def :up (args) _) `(def :down (args) _)]
        PATTERN

        def on_class(node)
          return if !migration_class?(node) || change_method?(node) || up_and_down_methods?(node)

          add_offense(node)
        end
      end
    end
  end
end

Version data entries

44 entries across 43 versions & 7 rubygems

Version Path
rubocop-rails-2.30.3 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.30.2 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.30.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.30.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
tailscale_middleware-0.0.3 vendor/cache/ruby/3.4.0/gems/rubocop-rails-2.29.1/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.29.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.29.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.27.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.26.2 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.26.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.26.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
blacklight-spotlight-3.6.0.beta8 vendor/bundle/ruby/3.2.0/gems/rubocop-rails-2.25.1/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.25.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
katalyst-govuk-formbuilder-1.9.2 vendor/bundle/ruby/3.3.0/gems/rubocop-rails-2.25.0/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.24.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.24.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
mlh-rubocop-config-1.0.3 vendor/bundle/ruby/3.2.0/gems/rubocop-rails-2.23.1/lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.23.1 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
rubocop-rails-2.23.0 lib/rubocop/cop/rails/reversible_migration_method_definition.rb
scrapbook-0.3.2 vendor/ruby/2.7.0/gems/rubocop-rails-2.20.0/lib/rubocop/cop/rails/reversible_migration_method_definition.rb