Contents

# encoding: utf-8
# frozen_string_literal: true

module RuboCop
  module Cop
    module ThreadSafety
      # Avoid mutating class and module attributes.
      #
      # They are implemented by class variables, which are not thread-safe.
      #
      # @example
      #   # bad
      #   class User
      #     cattr_accessor :current_user
      #   end
      class ClassAndModuleAttributes < Cop
        MSG = 'Avoid mutating class and module attributes.'.freeze

        def_node_matcher :mattr?, <<-END
          (send nil
            {:mattr_writer :mattr_accessor :cattr_writer :cattr_accessor}
            ...)
        END

        def_node_matcher :attr?, <<-END
          (send nil
            {:attr :attr_accessor :attr_writer}
            ...)
        END

        def on_send(node)
          return unless mattr?(node) || singleton_attr?(node)
          add_offense(node, :expression, format(MSG, node.source))
        end

        private

        def singleton_attr?(node)
          attr?(node) && node.ancestors.map(&:type).include?(:sclass)
        end
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version	Path
rubocop-thread_safety-0.3.3	lib/rubocop/cop/thread_safety/class_and_module_attributes.rb
rubocop-thread_safety-0.3.2	lib/rubocop/cop/thread_safety/class_and_module_attributes.rb
rubocop-thread_safety-0.3.1	lib/rubocop/cop/thread_safety/class_and_module_attributes.rb
rubocop-thread_safety-0.3.0	lib/rubocop/cop/thread_safety/class_and_module_attributes.rb
rubocop-thread_safety-0.2.0	lib/rubocop/cop/thread_safety/class_and_module_attributes.rb